Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lb creation issue and create wildcard cert for lb - centralised remote desktop solution #4243

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Fix lb creation issue and create wildcard cert for lb - centralised remote desktop solution #4243

merged 5 commits into from
Dec 5, 2023

Conversation

silvianahorga-al
Copy link
Contributor

No description provided.

@silvianahorga-al silvianahorga-al requested review from a team as code owners December 5, 2023 14:23
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-test December 5, 2023 14:24 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 14:25 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-test December 5, 2023 15:23 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 15:23 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@silvianahorga-al silvianahorga-al changed the title Create wildcard cert for lb - centralised remote desktop solution Fix lb creation issue and create wildcard cert for lb - centralised remote desktop solution Dec 5, 2023
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 15:29 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-test December 5, 2023 15:30 — with GitHub Actions Failure
pavmoj
pavmoj previously approved these changes Dec 5, 2023
View reviewed changes
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 16:08 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-test December 5, 2023 16:10 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-test December 5, 2023 16:14 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 16:15 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@silvianahorga-al silvianahorga-al had a problem deploying to hmpps-domain-services-development December 5, 2023 16:38 — with GitHub Actions Failure
@silvianahorga-al silvianahorga-al temporarily deployed to hmpps-domain-services-test December 5, 2023 16:38 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson ASTRobinson closed this Dec 5, 2023
@ASTRobinson ASTRobinson reopened this Dec 5, 2023
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Dec 5, 2023
@ASTRobinson ASTRobinson had a problem deploying to hmpps-domain-services-development December 5, 2023 16:56 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@silvianahorga-al silvianahorga-al merged commit 8172d2a into main Dec 5, 2023
29 of 32 checks passed
@silvianahorga-al silvianahorga-al deleted the csr/DSOS-2410/fix-lb-issue-and-setup-cert branch December 5, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavmoj pavmoj pavmoj approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvianahorga-al @pavmoj @ASTRobinson