Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ec2_test_instance::modernisation-platform-terraform-ec2-instance from 2.3.1 to 2.4.1 in /terraform/environments/example #4210

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 1, 2023

Bumps ec2_test_instance::modernisation-platform-terraform-ec2-instance from 2.3.1 to 2.4.1.

Release notes

Sourced from ec2_test_instance::modernisation-platform-terraform-ec2-instance's releases.

v2.4.1

What's Changed

Fix SSM parameter and secrets policy. Bug fix: changed "and" condition to "or". Ensures policy is created if either SSM Params or Secrets are created. Best practice: add minimum possible permissions (e.g. only need Put if there are placeholder params/secrets)

Full Changelog: ministryofjustice/modernisation-platform-terraform-ec2-instance@v2.4.0...v2.4.1

v2.4.0

What's New

  • SecretsManager secrets can now be populated with fixed or random values, and can have a recovery_window_in_days set.

What's Changed

New Contributors

Full Changelog: ministryofjustice/modernisation-platform-terraform-ec2-instance@v2.3.1...v2.4.0

Commits
  • edc55b4 Merge pull request #259 from ministryofjustice/dependabot/github_actions/brid...
  • 8d4230e DSOS-2423: ssm and secrets policy fix (#258)
  • 08738ef Bump bridgecrewio/checkov-action from 12.2600.0 to 12.2601.0
  • 4233b67 Merge pull request #257 from ministryofjustice/dependabot/github_actions/brid...
  • f677bd8 Merge pull request #256 from ministryofjustice/DSOS-2406-align-secretsmanager...
  • 8668189 Bump bridgecrewio/checkov-action from 12.2599.0 to 12.2600.0
  • 01e2451 add unit test
  • 48df51c fix
  • f1d4b2d fix
  • cc4e8af Merge pull request #255 from ministryofjustice/dependabot/github_actions/brid...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ec2_test_instance::modernisation-platform-terraform-ec2-instance](https://github.com/ministryofjustice/modernisation-platform-terraform-ec2-instance) from 2.3.1 to 2.4.1.
- [Release notes](https://github.com/ministryofjustice/modernisation-platform-terraform-ec2-instance/releases)
- [Commits](ministryofjustice/modernisation-platform-terraform-ec2-instance@v2.3.1...v2.4.1)

---
updated-dependencies:
- dependency-name: ec2_test_instance::github::ministryofjustice/modernisation-platform-terraform-ec2-instance::v2.3.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner December 1, 2023 11:55
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels Dec 1, 2023
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/observability-platform

*****************************

Running TFSEC in terraform/environments/observability-platform
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             730.842µs
  parsing              4.463748505s
  adaptation           206.194µs
  checks               4.656188ms
  total                4.469341729s

  counts
  ──────────────────────────────────────────
  modules downloaded   5
  modules processed    6
  blocks processed     219
  files read           35

  results
  ──────────────────────────────────────────
  passed               5
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/observability-platform

*****************************

Running Checkov in terraform/environments/observability-platform
2023-12-01 11:57:45,590 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~> 5.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 11:57:45,590 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/managed-service-prometheus/aws:~> 2.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 11:57:45,590 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/managed-service-grafana/aws:~> 2.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 11:57:45,590 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:~> 5.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 29, Failed checks: 0, Skipped checks: 5


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/observability-platform

*****************************

Running tflint in terraform/environments/observability-platform
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ASTRobinson ASTRobinson closed this Dec 1, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 1, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/ec2_test_instance--github--ministryofjustice/modernisation-platform-terraform-ec2-instance--v2.3.1-2.4.1 branch December 1, 2023 11:59
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/ec2_test_instance--github--ministryofjustice/modernisation-platform-terraform-ec2-instance--v2.3.1-2.4.1 branch December 1, 2023 12:01
@ASTRobinson ASTRobinson reopened this Dec 1, 2023
@ASTRobinson ASTRobinson temporarily deployed to example-development December 1, 2023 12:03 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Dec 1, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/observability-platform

*****************************

Running TFSEC in terraform/environments/observability-platform
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             686.87µs
  parsing              2.448945205s
  adaptation           201.305µs
  checks               6.903583ms
  total                2.456736963s

  counts
  ──────────────────────────────────────────
  modules downloaded   5
  modules processed    6
  blocks processed     219
  files read           35

  results
  ──────────────────────────────────────────
  passed               5
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/observability-platform

*****************************

Running Checkov in terraform/environments/observability-platform
2023-12-01 12:03:35,049 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-assumable-role:~> 5.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 12:03:35,049 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/managed-service-prometheus/aws:~> 2.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 12:03:35,050 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/managed-service-grafana/aws:~> 2.0 (for external modules, the --download-external-modules flag is required)
2023-12-01 12:03:35,050 [MainThread  ] [WARNI]  Failed to download module terraform-aws-modules/iam/aws//modules/iam-policy:~> 5.0 (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 29, Failed checks: 0, Skipped checks: 5


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/observability-platform

*****************************

Running tflint in terraform/environments/observability-platform
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ASTRobinson ASTRobinson merged commit 6d4406f into main Dec 1, 2023
21 of 22 checks passed
@ASTRobinson ASTRobinson deleted the dependabot/terraform/terraform/environments/example/ec2_test_instance--github--ministryofjustice/modernisation-platform-terraform-ec2-instance--v2.3.1-2.4.1 branch December 1, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file environments-repository Used to exclude PRs from this repo in our Slack PR update terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant