Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lb_access_logs_enabled::modernisation-platform-terraform-loadbalancer from 3.1.2 to 3.3.2 in /terraform/environments/example #4019

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 16, 2023

Bumps lb_access_logs_enabled::modernisation-platform-terraform-loadbalancer from 3.1.2 to 3.3.2.

Release notes

Sourced from lb_access_logs_enabled::modernisation-platform-terraform-loadbalancer's releases.

v3.3.2

What's Changed

Full Changelog: ministryofjustice/modernisation-platform-terraform-loadbalancer@v3.3.1...v3.3.2

v3.3.1

What's Changed

New Contributors

Full Changelog: ministryofjustice/modernisation-platform-terraform-loadbalancer@v3.3.0...v3.3.1

v3.3.0

What's Changed

New Contributors

Full Changelog: ministryofjustice/modernisation-platform-terraform-loadbalancer@v3.2.0...v3.3.0

v3.2.0

... (truncated)

Commits
  • 3150e0b Merge pull request #292 from ministryofjustice/feature/add_more_outputs
  • 0c6fd16 Merge pull request #295 from ministryofjustice/dependabot/github_actions/brid...
  • c8ca4ee Bump bridgecrewio/checkov-action from 12.2575.0 to 12.2576.0
  • 2aef2eb Merge pull request #294 from ministryofjustice/dependabot/github_actions/brid...
  • 279c505 Bump bridgecrewio/checkov-action from 12.2572.0 to 12.2575.0
  • 0953cd8 terraform-docs: automated action
  • 097222b added dns name and zone id outputs
  • 2e3dd3c Merge pull request #291 from ministryofjustice/feature/glue-fixes
  • c2c7fea update path
  • 624f9a1 glue crawler terraform fix
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 16, 2023 00:38
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels Nov 16, 2023
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Nov 16, 2023
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch from bc0b56d to 34dff46 Compare November 27, 2023 09:28
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 27, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch November 27, 2023 09:30
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch November 27, 2023 09:30
@ASTRobinson ASTRobinson reopened this Nov 27, 2023
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch from 34dff46 to d77151a Compare November 27, 2023 15:49
@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch November 27, 2023 15:50
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch November 27, 2023 15:50
@ASTRobinson ASTRobinson reopened this Nov 27, 2023
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch from d77151a to 1e81e54 Compare November 29, 2023 11:18
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson ASTRobinson closed this Dec 4, 2023
@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 4, 2023 11:11
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 4, 2023 11:11
@ASTRobinson ASTRobinson reopened this Dec 4, 2023
Copy link
Contributor

github-actions bot commented Dec 4, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/planetfm

*****************************

Running TFSEC in terraform/environments/planetfm
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.38619ms
  parsing              177.782455ms
  adaptation           107.511µs
  checks               6.936783ms
  total                186.212939ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     271
  files read           71

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/planetfm

*****************************

Running Checkov in terraform/environments/planetfm
terraform scan results:

Passed checks: 94, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/planetfm

*****************************

Running tflint in terraform/environments/planetfm
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Copy link
Contributor

github-actions bot commented Dec 4, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/planetfm

*****************************

Running TFSEC in terraform/environments/planetfm
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.449291ms
  parsing              182.29967ms
  adaptation           107.15µs
  checks               5.483089ms
  total                189.3392ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     271
  files read           71

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/planetfm

*****************************

Running Checkov in terraform/environments/planetfm
terraform scan results:

Passed checks: 94, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/planetfm

*****************************

Running tflint in terraform/environments/planetfm
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@ASTRobinson
Copy link
Contributor

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch from d4c87be to 2224975 Compare December 8, 2023 09:58
Copy link
Contributor

github-actions bot commented Dec 8, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running TFSEC in terraform/environments/nomis-data-hub
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.351928ms
  parsing              200.055347ms
  adaptation           224.691µs
  checks               6.834839ms
  total                208.466805ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     265
  files read           68

  results
  ──────────────────────────────────────────
  passed               7
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running Checkov in terraform/environments/nomis-data-hub
terraform scan results:

Passed checks: 102, Failed checks: 12, Skipped checks: 19

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_host_os"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_admin_user"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_harkemsadmin_ssl_pass"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_app_host_a"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_port_1"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_app_host_b"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_host_a"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_admin_pass"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_host_os_version"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_port_2"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_host_b"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_domain_name"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }


checkov_exitcode=1

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running tflint in terraform/environments/nomis-data-hub
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: Missing version constraint for provider "random" in "required_providers" (terraform_required_providers)

  on terraform/environments/nomis-data-hub/main.tf line 99:
  99: resource "random_password" "random_value" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.1/docs/rules/terraform_required_providers.md

tflint_exitcode=2

@ASTRobinson ASTRobinson closed this Dec 8, 2023
@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 8, 2023 10:04
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 8, 2023 10:04
@ASTRobinson ASTRobinson reopened this Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running TFSEC in terraform/environments/nomis-data-hub
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.426054ms
  parsing              222.349745ms
  adaptation           140.933µs
  checks               4.649347ms
  total                228.566079ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     265
  files read           68

  results
  ──────────────────────────────────────────
  passed               7
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running Checkov in terraform/environments/nomis-data-hub
terraform scan results:

Passed checks: 102, Failed checks: 12, Skipped checks: 19

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_host_a"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_domain_name"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_app_host_b"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_host_os"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_admin_user"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_app_host_a"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_port_2"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_harkemsadmin_ssl_pass"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_admin_pass"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_host_b"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_host_os_version"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.ndh_secrets["ndh_ems_port_1"]
	File: /main.tf:104-114

		104 | resource "aws_ssm_parameter" "ndh_secrets" {
		105 |   for_each = toset(local.ndh_secrets)
		106 |   name     = each.value
		107 |   type     = "SecureString"
		108 |   value    = random_password.random_value.result
		109 |   lifecycle {
		110 |     ignore_changes = [
		111 |       value,
		112 |     ]
		113 |   }
		114 | }


checkov_exitcode=1

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/nomis-data-hub

*****************************

Running tflint in terraform/environments/nomis-data-hub
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: Missing version constraint for provider "random" in "required_providers" (terraform_required_providers)

  on terraform/environments/nomis-data-hub/main.tf line 99:
  99: resource "random_password" "random_value" {

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.2.1/docs/rules/terraform_required_providers.md

tflint_exitcode=2

@ASTRobinson
Copy link
Contributor

@dependabot rebase

…ancer

Bumps [lb_access_logs_enabled::modernisation-platform-terraform-loadbalancer](https://github.com/ministryofjustice/modernisation-platform-terraform-loadbalancer) from 3.1.2 to 3.3.2.
- [Release notes](https://github.com/ministryofjustice/modernisation-platform-terraform-loadbalancer/releases)
- [Commits](ministryofjustice/modernisation-platform-terraform-loadbalancer@v3.1.2...v3.3.2)

---
updated-dependencies:
- dependency-name: lb_access_logs_enabled::github::ministryofjustice/modernisation-platform-terraform-loadbalancer::v3.1.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch from 2224975 to ee88762 Compare December 11, 2023 10:31
@dependabot dependabot bot deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 11, 2023 10:32
@ASTRobinson ASTRobinson restored the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 11, 2023 10:32
@ASTRobinson ASTRobinson reopened this Dec 11, 2023
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

1 similar comment
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@ASTRobinson ASTRobinson merged commit 3932528 into main Dec 11, 2023
18 of 20 checks passed
@ASTRobinson ASTRobinson deleted the dependabot/terraform/terraform/environments/example/lb_access_logs_enabled--github--ministryofjustice/modernisation-platform-terraform-loadbalancer--v3.1.2-3.3.2 branch December 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file environments-repository Used to exclude PRs from this repo in our Slack PR update terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant