Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DSOS-2332: baesline fix for adding secrets to EC2 #3891

Merged
merged 1 commit into from
Nov 6, 2023
Merged

DSOS-2332: baesline fix for adding secrets to EC2 #3891

merged 1 commit into from
Nov 6, 2023

Conversation

drobinson-moj
Copy link
Contributor

The EC2 instance module doesn't support null for this parameter. Setting it to empty dict instead

@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Nov 6, 2023
@drobinson-moj drobinson-moj merged commit 8ddc364 into main Nov 6, 2023
6 checks passed
@drobinson-moj drobinson-moj deleted the DSOS-2332/baseline-fix-for-ec2-secrets branch November 6, 2023 14:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2023

TFSEC Scan Success

Show Output 
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output 
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

IjazMoJ pushed a commit that referenced this pull request Nov 7, 2023
@drobinson-moj @IjazMoJ
DSOS-2332: fix for adding secrets to EC2 (#3891)
2582154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonygowland antonygowland antonygowland approved these changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drobinson-moj @antonygowland