Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform Infra rebuilt #3704

Closed
wants to merge 2 commits into from
Closed

Conversation

IjazMoJ
Copy link
Contributor

@IjazMoJ IjazMoJ commented Oct 17, 2023

No description provided.

@IjazMoJ IjazMoJ requested review from a team as code owners October 17, 2023 14:46
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Oct 17, 2023
@IjazMoJ IjazMoJ had a problem deploying to planetfm-development October 17, 2023 14:48 — with GitHub Actions Failure
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running TFSEC in terraform/environments/hmpps-domain-services
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             2.202616ms
  parsing              224.89397ms
  adaptation           142.307µs
  checks               9.733118ms
  total                236.972011ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     270
  files read           72

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running Checkov in terraform/environments/hmpps-domain-services
terraform scan results:

Passed checks: 94, Failed checks: 3, Skipped checks: 19

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.linux-join-ad-account-username
	File: /ssm.tf:2-12

		2  | resource "aws_ssm_parameter" "linux-join-ad-account-username" {
		3  |   name        = "Linux Join Domain Service Account Username"
		4  |   type        = "SecureString"
		5  |   value       = "INITIAL_VALUE_OVERRIDDEN"
		6  |   description = "Username to join linux machines to azure.noms.root domain"
		7  |   tags        = local.tags
		8  | 
		9  |   lifecycle {
		10 |     ignore_changes = [value]
		11 |   }
		12 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.linux-join-ad-account-password
	File: /ssm.tf:14-24

		14 | resource "aws_ssm_parameter" "linux-join-ad-account-password" {
		15 |   name        = "Linux Join Domain Service Account Password"
		16 |   type        = "SecureString"
		17 |   value       = "INITIAL_VALUE_OVERRIDDEN"
		18 |   description = "Password to join linux machines to azure.noms.root domain"
		19 |   tags        = local.tags
		20 | 
		21 |   lifecycle {
		22 |     ignore_changes = [value]
		23 |   }
		24 | }
Check: CKV_AWS_103: "Ensure that load balancer is using at least TLS 1.2"
	FAILED for resource: module.baseline.module.lb_listener.aws_lb_listener.this
	File: /../../modules/lb_listener/main.tf:1-61
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-general-policies/bc-aws-general-43.html

		Code lines for this resource are too many. Please use IDE of your choice to review the file.

checkov_exitcode=1

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running tflint in terraform/environments/hmpps-domain-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@IjazMoJ IjazMoJ requested review from a team as code owners October 17, 2023 14:54
@IjazMoJ IjazMoJ had a problem deploying to planetfm-development October 17, 2023 14:56 — with GitHub Actions Failure
@IjazMoJ IjazMoJ had a problem deploying to wardship-development October 17, 2023 14:56 — with GitHub Actions Failure
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running TFSEC in terraform/environments/hmpps-domain-services
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.484298ms
  parsing              173.949804ms
  adaptation           124.199µs
  checks               16.452906ms
  total                192.011207ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     270
  files read           72

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Failed

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running Checkov in terraform/environments/hmpps-domain-services
terraform scan results:

Passed checks: 94, Failed checks: 3, Skipped checks: 19

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.linux-join-ad-account-username
	File: /ssm.tf:2-12

		2  | resource "aws_ssm_parameter" "linux-join-ad-account-username" {
		3  |   name        = "Linux Join Domain Service Account Username"
		4  |   type        = "SecureString"
		5  |   value       = "INITIAL_VALUE_OVERRIDDEN"
		6  |   description = "Username to join linux machines to azure.noms.root domain"
		7  |   tags        = local.tags
		8  | 
		9  |   lifecycle {
		10 |     ignore_changes = [value]
		11 |   }
		12 | }

Check: CKV_AWS_337: "Ensure SSM parameters are using KMS CMK"
	FAILED for resource: aws_ssm_parameter.linux-join-ad-account-password
	File: /ssm.tf:14-24

		14 | resource "aws_ssm_parameter" "linux-join-ad-account-password" {
		15 |   name        = "Linux Join Domain Service Account Password"
		16 |   type        = "SecureString"
		17 |   value       = "INITIAL_VALUE_OVERRIDDEN"
		18 |   description = "Password to join linux machines to azure.noms.root domain"
		19 |   tags        = local.tags
		20 | 
		21 |   lifecycle {
		22 |     ignore_changes = [value]
		23 |   }
		24 | }
Check: CKV_AWS_103: "Ensure that load balancer is using at least TLS 1.2"
	FAILED for resource: module.baseline.module.lb_listener.aws_lb_listener.this
	File: /../../modules/lb_listener/main.tf:1-61
	Guide: https://docs.paloaltonetworks.com/content/techdocs/en_US/prisma/prisma-cloud/prisma-cloud-code-security-policy-reference/aws-policies/aws-general-policies/bc-aws-general-43.html

		Code lines for this resource are too many. Please use IDE of your choice to review the file.

checkov_exitcode=1

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/hmpps-domain-services

*****************************

Running tflint in terraform/environments/hmpps-domain-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@IjazMoJ IjazMoJ closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant