Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unneeded resources for data-and-insights #3473

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Sep 25, 2023

  • Since customers will access the redshift cluster directly, there's no need for an intervening load balancer.
  • Using a loadbalancer with a Route53 record and then forwarding to redshift fails on certificate match.
  • As there's no way to provide a custom domain name that's compliant with MOJ naming standards inside the character limit, there's no value to creating a custom certificate.

@dms1981 dms1981 requested review from a team as code owners September 25, 2023 09:48
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Sep 25, 2023
@dms1981 dms1981 had a problem deploying to data-and-insights-wepi-development September 25, 2023 09:50 — with GitHub Actions Failure
@github-actions
Copy link
Contributor

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:

@dms1981 dms1981 deployed to data-and-insights-wepi-development September 25, 2023 10:20 — with GitHub Actions Active
@dms1981 dms1981 merged commit 3ba2796 into main Sep 26, 2023
13 checks passed
@dms1981 dms1981 deleted the feature/data-and-insights-cleanup branch September 26, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants