generated from ministryofjustice/template-repository
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSOS-2123: add oem secretmanager secrets #3352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
environments-repository
Used to exclude PRs from this repo in our Slack PR update
label
Sep 13, 2023
drobinson-moj
temporarily deployed
to
hmpps-oem-test
September 13, 2023 09:54 — with
GitHub Actions
Inactive
drobinson-moj
temporarily deployed
to
hmpps-oem-development
September 13, 2023 09:54 — with
GitHub Actions
Inactive
drobinson-moj
temporarily deployed
to
nomis-development
September 13, 2023 09:55 — with
GitHub Actions
Inactive
|
wullub
approved these changes
Sep 13, 2023
vladimir-kovalyov
pushed a commit
that referenced
this pull request
Sep 14, 2023
* add resources option to secretmanager policy * add oem secrets and policy * whitespace * fix * test * fix * rename secret * add EC2 policy for updating secrets * update baseline opts * fix * fix * fix * fix * fix * fix * update secrets policy * test * fix * fix * test * test * test * test * test * test * test * add EMREP secret * add Get Secret and Parameter policies * allow GetResourcePolicy * allow GetResourcePolicy * Remove ResourcePolicy permission * add PutResourcePolicy * test * update policy * update naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store OEM passwords as SecretManager Secrets so they can be shared across accounts.
Add relevant policies and the placeholder secrets themselves.