- Do not take automatic DB snapshot upon terraform destroy. Because w…

…e would do a manual snapshot anyway. Removed the configuration final_snapshot_identifier="final-snapshot" from resource "aws_db_instance" "database".

- Update db_snapshot_identifier for performance hub preproduction

terraform/environments/performance-hub/application_variables.json

@@ -47,7 +47,7 @@
           "db_instance_class": "db.m5.large",
           "db_user": "admin",
           "db_allocated_storage": "100",
-          "db_snapshot_identifier": "arn:aws:rds:eu-west-2:322518575883:snapshot:performance-hub-final-snapshot-06102021",
+          "db_snapshot_identifier": "arn:aws:rds:eu-west-2:322518575883:snapshot:performance-hub-final-snapshot-02032022",
           "env_name": "preproduction",
           "system_account_id": "C67AF61C-F010-4C37-8912-99308FD03241",
           "friendly_name": "HMPPS Test Hub",

terraform/environments/performance-hub/main.tf

@@ -372,7 +372,6 @@ resource "aws_db_instance" "database" {
   backup_retention_period             = 30
   maintenance_window                  = "Mon:00:00-Mon:03:00"
   backup_window                       = "03:00-06:00"
-  final_snapshot_identifier           = "final-snapshot"
   kms_key_id                          = aws_kms_key.rds.arn
   deletion_protection                 = false
   option_group_name                   = aws_db_option_group.db_option_group.name