Skip to content

Commit

Permalink
Merge pull request #8694 from ministryofjustice/date_2024_11_18
Browse files Browse the repository at this point in the history
GitHub Actions Code Formatter workflow
  • Loading branch information
ASTRobinson authored Nov 18, 2024
2 parents ac7a3e6 + c2c78a8 commit 89b4b48
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resource "aws_cloudtrail" "trail" {
include_global_service_events = true
enable_log_file_validation = true

kms_key_id = aws_kms_key.cloudtrail.key_id # Get KEY ID from Resource
kms_key_id = aws_kms_key.cloudtrail.key_id # Get KEY ID from Resource


event_selector {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ module "data_ingestion_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_temp_reload_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "false",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down Expand Up @@ -194,7 +194,7 @@ module "data_ingestion_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module "maintenance_pipeline" {
"JobName" : var.glue_unprocessed_raw_files_check_job,
"Arguments" : {
"--dpr.orchestration.wait.interval.seconds" : "60",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ module "reload_pipeline" {
"--dpr.file.transfer.source.bucket" : var.s3_raw_bucket_id,
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down Expand Up @@ -121,7 +121,7 @@ module "reload_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_temp_reload_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "false",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down Expand Up @@ -233,7 +233,7 @@ module "reload_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand All @@ -253,7 +253,7 @@ module "reload_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand All @@ -273,7 +273,7 @@ module "reload_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ module "replay_pipeline" {
"--dpr.file.transfer.source.bucket" : var.s3_curated_bucket_id,
"--dpr.file.transfer.destination.bucket" : var.s3_temp_reload_bucket_id,
"--dpr.file.transfer.delete.copied.files" : "false",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down Expand Up @@ -131,7 +131,7 @@ module "replay_pipeline" {
"--dpr.file.transfer.source.bucket" : var.s3_raw_bucket_id,
"--dpr.file.transfer.destination.bucket" : var.s3_raw_archive_bucket_id,
"--dpr.file.transfer.delete.copied.files" : "true",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand All @@ -150,7 +150,7 @@ module "replay_pipeline" {
"--dpr.file.transfer.destination.bucket" : var.s3_raw_bucket_id,
"--dpr.file.transfer.retention.period.amount" : "0",
"--dpr.file.transfer.delete.copied.files" : "false",
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.maxAttempts" : tostring(var.glue_s3_max_attempts),
"--dpr.datastorage.retry.minWaitMillis" : tostring(var.glue_s3_retry_min_wait_millis),
"--dpr.datastorage.retry.maxWaitMillis" : tostring(var.glue_s3_retry_max_wait_millis),
"--dpr.config.s3.bucket" : var.s3_glue_bucket_id,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module "test_ap_airflow" {
module "load_alcohol_monitoring_database" {
count = local.is-production ? 1 : 0
source = "./modules/ap_airflow_load_data_iam_role"

name = "alcohol-monitoring"
environment = local.environment
database_name = "capita-alcohol-monitoring"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ module "this-bucket" {
# Optionally add cross account access to bucket policy.
bucket_policy_v2 = var.cross_account_access_role != null ? [
{
sid = "CrossAccountAccess"
effect = "Allow"
sid = "CrossAccountAccess"
effect = "Allow"
actions = [
"s3:PutObject",
"s3:PutObjectAcl"
Expand All @@ -68,7 +68,7 @@ module "this-bucket" {
type = "AWS"
}
}
] : []
] : []

tags = merge(
var.local_tags,
Expand Down
4 changes: 2 additions & 2 deletions terraform/environments/electronic-monitoring-data/s3.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ locals {
"production" = null
"preproduction" = {
"account_number" = 173142358744
"role_name" = "juniper-dt-lambda-role"
"role_name" = "juniper-dt-lambda-role"
}
"test" = {
"account_number" = 173142358744
role_name = "dev-dt-lambda-role"
role_name = "dev-dt-lambda-role"
}
"development" = null
}
Expand Down
2 changes: 1 addition & 1 deletion terraform/environments/ppud/iam.tf
Original file line number Diff line number Diff line change
Expand Up @@ -893,7 +893,7 @@ data "aws_iam_policy_document" "sns_topic_policy_ec2cw" {
resources = [
aws_sns_topic.cw_alerts[0].arn
]
}
}
}

####################################################
Expand Down

0 comments on commit 89b4b48

Please sign in to comment.