Skip to content

Commit

Permalink
Remove s3_ap_landing_role for now
Browse files Browse the repository at this point in the history
  • Loading branch information
jemnery committed Nov 20, 2023
1 parent 08927e3 commit 743c619
Showing 1 changed file with 33 additions and 33 deletions.
66 changes: 33 additions & 33 deletions terraform/environments/performance-hub/iam.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,39 +6,39 @@
# S3 bucket access policy for AP landing bucket (data pushed from
# Performance Hub to a bucket in the AP account - hence hard-coded bucket name)

resource "aws_iam_role" "s3_ap_landing_role" {
name = "${local.application_name}-s3-ap-landing-role"
assume_role_policy = jsonencode({
Version = "2012-10-17"
Statement = [
{
Sid: "MOJAnalyticalPlatformListBucket",
Effect: "Allow",
Action: [
"s3:ListBucket",
"s3:GetBucketLocation"
],
"Resource": "arn:aws:s3:::hmpps-performance-hub-landing"
},
{
Sid: "MOJAnalyticalPlatformWriteBucket",
Effect: "Allow",
Action: [
"s3:PutObject",
"s3:PutObjectAcl",
"s3:GetObject"
],
Resource: "arn:aws:s3:::hmpps-performance-hub-landing/*"
}
]
})
tags = merge(
local.tags,
{
Name = "${local.application_name}-s3-ap-landing-role"
}
)
}
# resource "aws_iam_role" "s3_ap_landing_role" {
# name = "${local.application_name}-s3-ap-landing-role"
# assume_role_policy = jsonencode({
# Version = "2012-10-17"
# Statement = [
# {
# Sid: "MOJAnalyticalPlatformListBucket",
# Effect: "Allow",
# Action: [
# "s3:ListBucket",
# "s3:GetBucketLocation"
# ],
# "Resource": "arn:aws:s3:::hmpps-performance-hub-landing"
# },
# {
# Sid: "MOJAnalyticalPlatformWriteBucket",
# Effect: "Allow",
# Action: [
# "s3:PutObject",
# "s3:PutObjectAcl",
# "s3:GetObject"
# ],
# Resource: "arn:aws:s3:::hmpps-performance-hub-landing/*"
# }
# ]
# })
# tags = merge(
# local.tags,
# {
# Name = "${local.application_name}-s3-ap-landing-role"
# }
# )
# }


# S3 bucket access policy for Performance Hub landing bucket (data pushed from
Expand Down

0 comments on commit 743c619

Please sign in to comment.