Skip to content

Commit

Permalink
DPR2-1435: Make postgres_settings configuration block conditional on …
Browse files Browse the repository at this point in the history
…the engine type being postgres. (#8822)

This avoids the terraform plan being polluted with changes to postgres settings for oracle sources that need reapplying on every terraform run.
  • Loading branch information
tom-ogle-moj authored Nov 27, 2024
1 parent fc4bdf6 commit 66991bf
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,14 @@ resource "aws_dms_endpoint" "dms-s3-target-source" {
ssl_mode = var.source_ssl_mode
username = var.source_app_username

postgres_settings {
map_boolean_as_boolean = true
heartbeat_enable = true
heartbeat_frequency = 5
dynamic postgres_settings {
for_each = var.source_engine_name == "postgres" ? [1]: []

content {
map_boolean_as_boolean = true
heartbeat_enable = true
heartbeat_frequency = 5
}
}

extra_connection_attributes = var.extra_attributes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ variable "source_engine" {
variable "source_engine_name" {
default = ""
type = string
description = "Engine name for DMS"
description = "Type of engine for the source endpoint. Example valid values are postgres, oracle"
}


Expand Down

0 comments on commit 66991bf

Please sign in to comment.