Disable shell mode, too hard to read

Remove "not found" statement, too noisy and hard to grep Signed-off-by: Jacob Woffenden <[email protected]>
ministryofjustice · Oct 23, 2024 · 4f39f25 · 4f39f25
1 parent ffa54db
commit 4f39f25
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.github/workflows/reusable_terraform_plan_apply.yml b/.github/workflows/reusable_terraform_plan_apply.yml
@@ -162,7 +162,7 @@ jobs:
         working-directory: "terraform/environments/${{ inputs.application }}"
         shell: bash
         run: |
-          bash -x ${GITHUB_WORKSPACE}/scripts/terraform-plan-evaluator.sh tfplan.json
+          bash ${GITHUB_WORKSPACE}/scripts/terraform-plan-evaluator.sh tfplan.json
 
       - name: Create Plan PR message (Optional)
         if: github.event_name == 'pull_request' && steps.plan.outputs.exitcode == '2' && inputs.post_plan_to_pr == true

diff --git a/scripts/terraform-plan-evaluator.sh b/scripts/terraform-plan-evaluator.sh
@@ -33,12 +33,11 @@ RESOURCES_TO_CHECK_FOR=(
 resourcesFound=false
 
 for resource in "${RESOURCES_TO_CHECK_FOR[@]}"; do
+  echo "Checking for resource: ${resource}"
   checkForResource=$(jq -r --arg resourceType "${resource}" '.resource_changes[] | select(.type == $resourceType) | .change.actions[] | select(. != "no-op" and . != "read")' "${TERRAFORM_PLAN}")
   if [[ -n "${checkForResource}" ]]; then
     echo "Resource ${resource} found in plan"
     resourcesFound=true
-  else
-    echo "Resource ${resource} not found in plan"
   fi
 done