Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: LGA-2589 Updating PROVIDER_CATEGORIES with hlpas value #236

Merged
merged 10 commits into from
Jul 31, 2023

Conversation

psweeting1
Copy link
Contributor

@psweeting1 psweeting1 commented Jul 27, 2023

What does this pull request do?

Required.

Any other changes that would benefit highlighting?

Encountered error with cython upgrade to version 3.0. This means that pyyaml will not load.

yaml/pyyaml#601

Had to update awscli to version 2 in order that this bug is fixed. Could not update to the latest version of 1 as this was not supported by the remote docker image we were using in circleci to create the docker image

aws/aws-cli#5943

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@psweeting1 psweeting1 requested a review from a team as a code owner July 27, 2023 12:44
Pinning pyyaml to prevent error with cython 3.0
Adding back pre-commit at current value as it was not the problem
@jogilder jogilder force-pushed the feature/LGA-2589-HLPAS-Filter branch from ee63aa9 to 7a6d7cc Compare July 27, 2023 16:14
jogilder and others added 8 commits July 27, 2023 17:23
Issue with cython 3 was fixed in 6.0.1 version of pyyaml, this was not allowed by lower version of awscli
Need to use a higher version of awscli to get round pyyaml cython issue
Need to use a higher version of awscli to get round pyyaml cython issue
Need to use a higher version of awscli to get round pyyaml cython issue
Not sure this was actually needed here at all, was just awscli that had it.
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@TawneeOwl TawneeOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@said-moj said-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@psweeting1 psweeting1 merged commit 9617e29 into master Jul 31, 2023
@psweeting1 psweeting1 deleted the feature/LGA-2589-HLPAS-Filter branch July 31, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants