-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: LGA-2589 Updating PROVIDER_CATEGORIES with hlpas value #236
Conversation
Pinning pyyaml to prevent error with cython 3.0 Adding back pre-commit at current value as it was not the problem
ee63aa9
to
7a6d7cc
Compare
Issue with cython 3 was fixed in 6.0.1 version of pyyaml, this was not allowed by lower version of awscli
Need to use a higher version of awscli to get round pyyaml cython issue
Need to use a higher version of awscli to get round pyyaml cython issue
Need to use a higher version of awscli to get round pyyaml cython issue
Not sure this was actually needed here at all, was just awscli that had it.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
What does this pull request do?
Required.
Any other changes that would benefit highlighting?
Encountered error with cython upgrade to version 3.0. This means that pyyaml will not load.
yaml/pyyaml#601
Had to update awscli to version 2 in order that this bug is fixed. Could not update to the latest version of 1 as this was not supported by the remote docker image we were using in circleci to create the docker image
aws/aws-cli#5943
Checklist