MAP-1920 Fix weekly report #2428
Merged
+51
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnioche-jd
previously approved these changes
Dec 2, 2024
tobyprivett
changed the title
tobyprivett
force-pushed
the
bug/remove-sql-indentation
branch
2 times, most recently
from
0184713 to
5049c54
Compare
- Remove indentation from SQL - Remove wildcard * from subquery - Lowercase SQL keywords
tobyprivett
force-pushed
the
bug/remove-sql-indentation
branch
from
5049c54 to
bbf45c9
Compare
danbenton-mojdt
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
MAP-1920
What?
*from subqueryWhy?
The weekly reports failed, and came through empty / with no results.
We can run these reports locally or validate the SQL so this is a trial and error approach.