Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rubocop-govuk #2417

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Update rubocop-govuk #2417

merged 1 commit into from
Nov 22, 2024

Conversation

tobyprivett
Copy link
Contributor

@tobyprivett tobyprivett commented Nov 21, 2024 •
edited
Loading

  • rubocop-govuk was pinned to a pre-release commit - new version has been released.

@tobyprivett tobyprivett requested a review from a team as a code owner November 21, 2024 09:26
@tobyprivett tobyprivett mentioned this pull request Nov 21, 2024
Closed
@tobyprivett tobyprivett changed the title Chore: Update rubocop-govuk, json-schema, sidekiq Update rubocop-govuk Nov 22, 2024
Mjwillis
Mjwillis approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobyprivett tobyprivett merged commit 547df82 into main Nov 22, 2024
8 checks passed
@tobyprivett tobyprivett deleted the update-rubocop-govuk branch November 22, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mjwillis Mjwillis Mjwillis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobyprivett @Mjwillis