MAP-1781 Cleanup Access Logs more than 3 months old #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyprivett
force-pushed
the
MAP-1781-access-logs
branch
from
6ae1fce to
8064004
Compare
|
I think three months is too short tbh, I've had to debug issues with older moves before |
jimbali
previously approved these changes
Nov 15, 2024
| AccessLog.where('timestamp < ?', cutoff_date).limit(1000).delete_all | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I would suggest possibly adding a test for this task but it's up to you
tobyprivett
force-pushed
the
MAP-1781-access-logs
branch
from
424fb68 to
815c129
Compare
Agree, minimum 12 months imo |
jimbali
approved these changes
Nov 15, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
https://dsdmoj.atlassian.net/browse/MAP-1781
What?
Adds a daily cronjob to delete stale Access Logs.
DELETE can be a very expensive operation, so we do this in batches of 1000.
Why?
200k Access Logs are created every day.
We use them for debugging production issues, so it should be okay to remove anything older than three months.