MAP-1665 Migrate to the new Alerts API #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyprivett
force-pushed
the
MAP-1665-alerts-api
branch
4 times, most recently
from
8c012c8 to
57f968e
Compare
tobyprivett
changed the title
tobyprivett
force-pushed
the
MAP-1665-alerts-api
branch
2 times, most recently
from
1f7317e to
3845398
Compare
tobyprivett
force-pushed
the
MAP-1665-alerts-api
branch
from
5bde20e to
c98792c
Compare
Mjwillis
approved these changes
Oct 24, 2024
| "ALERTS_API_BASE_URL": { | ||
| "description": "Base URL for Alerts API", | ||
| "required": true | ||
| }, | ||
| "NOMIS_SITE_FOR_API": { | ||
| "description": "Base URL for NOMIS API", |
There was a problem hiding this comment.
Probably should call this prison-api
There was a problem hiding this comment.
Both Prison API and NOMIS API are used all over the app, unfortunately.
| @@ -15,6 +15,10 @@ | |||
| "description": "Name of the storage bucket to use on AWS S3", | |||
| "required": true | |||
| }, | |||
| "ALERTS_API_BASE_URL": { | |||
There was a problem hiding this comment.
Are all URL added to config?
| @@ -41,6 +41,7 @@ generic-service: | |||
| NOMIS_API_PATH_PREFIX: nomis_api_path_prefix_key | |||
| NOMIS_PRISON_API_PATH_PREFIX: nomis_prison_api_path_prefix_key | |||
| NOMIS_AUTH_PATH_PREFIX: nomis_auth_path_prefix_key | |||
| ALERTS_API_BASE_URL: alerts_api_base_url_key | |||
| @@ -36,6 +36,7 @@ generic-service: | |||
| NOMIS_AUTH_SCHEME: nomis_auth_scheme_key | |||
| NOMIS_API_PATH_PREFIX: nomis_api_path_prefix_key | |||
| NOMIS_PRISON_API_PATH_PREFIX: nomis_prison_api_path_prefix_key | |||
| ALERTS_API_BASE_URL: alerts_api_base_url_key | |||
There was a problem hiding this comment.
Where do the values get addded?
There was a problem hiding this comment.
As Kube secrets
NOTE: base class currently duplicates the NomisClient::Base - refactor / DRY up
tobyprivett
force-pushed
the
MAP-1665-alerts-api
branch
from
c98792c to
e661bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link
MAP-1665
What?
with the Alerts API (Alerts / Alert Types)
NomisClienttoHmppsClientWhy?
The Prison API Alerts endpoint has been deprecated.
Deployment risks
STAGING: https://alerts-api-dev.hmpps.service.justice.gov.uk/
PREPROD / UAT: https://alerts-api-preprod.hmpps.service.justice.gov.uk/
PROD: https://alerts-api.hmpps.service.justice.gov.uk/