Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.1 pt2 #2316

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Rails 7.1 pt2 #2316

merged 2 commits into from
Sep 2, 2024

Conversation

jimbali
Copy link
Contributor

@jimbali jimbali commented Aug 30, 2024

Jira link

MAP-1477

What?

I have added/removed/altered:

  • Enable most Rails 7.1 defaults
  • Get rid of the unnecessary guff that gets printed to the console during tests

Why?

I am doing this because:

  • To continue with the Rails 7.1 upgrade and get ready for 7.2
  • To make it easier to spot deprecation errors logged during test runs

Deployment risks (optional)

  • Some of these changes needed to only be deployed after all pods were running 7.1 (which they now are)

Also delete secrets.yml as it's unnecessary now and will be removed in 7.2

MAP-1477#
…le during tests

This should make it easier to spot deperecation warnings.

MAP-1477
@jimbali jimbali marked this pull request as ready for review August 30, 2024 15:07
@jimbali jimbali requested a review from a team as a code owner August 30, 2024 15:07
Copy link
Contributor

@Mjwillis Mjwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mjwillis Mjwillis merged commit a79711b into main Sep 2, 2024
8 checks passed
@Mjwillis Mjwillis deleted the rails-7.1-pt2 branch September 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants