Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAP-340: Let journey take precedence over lodge when filtering #2195

Merged
merged 1 commit into from
Dec 1, 2023
Merged

MAP-340: Let journey take precedence over lodge when filtering #2195

merged 1 commit into from
Dec 1, 2023

Conversation

jimbali
Copy link
Contributor

@jimbali jimbali commented Nov 30, 2023 •
edited
Loading

Jira link

MAP-340

What?

I have added/removed/altered:

  • Only show moves on the incoming/outgoing pages relative to the journey, if there is both a lodge and journey

Why?

I am doing this because:

  • If the journey is booked for a different location to the lodge then we assume that the journey is correct and the lodge isn't, as it's more up-to-date

Deployment risks

  • Possible performance impact - we will test for this before going live

@jimbali jimbali requested a review from a team as a code owner November 30, 2023 12:03
@jimbali jimbali merged commit 8aaa01c into main Dec 1, 2023
8 checks passed
@jimbali jimbali deleted the lodge-journey-clash--MAP-340 branch December 1, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbenton-mojdt danbenton-mojdt danbenton-mojdt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimbali @danbenton-mojdt