Skip to content

Commit

Permalink
MAP-293: Add incomplete_per as a cancellation reason for moves
Browse files Browse the repository at this point in the history
Suppliers have been asked by PECS to reject moves with an incomplete PER,
but they want it to be clear why they have cancelled the move so that they
are not penalised for unnecessary cancellations.
  • Loading branch information
jimbali committed Nov 9, 2023
1 parent 2a681c6 commit b73055d
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/models/move.rb
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class Move < VersionedModel
CANCELLATION_REASON_CANCELLED_BY_PMU = 'cancelled_by_pmu',
CANCELLATION_REASON_REJECTED = 'rejected',
CANCELLATION_REASON_DATABASE_CORRECTION = 'database_correction',
CANCELLATION_REASON_INCOMPLETE_PER = 'incomplete_per',
CANCELLATION_REASON_OTHER = 'other',
].freeze

Expand Down
1 change: 1 addition & 0 deletions spec/models/move_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
supplier_declined_to_move
cancelled_by_pmu
rejected
incomplete_per
other
])
}
Expand Down
1 change: 1 addition & 0 deletions spec/swagger/swagger_doc_v1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,7 @@
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
- name: filter[rejection_reason]
in: query
Expand Down
1 change: 1 addition & 0 deletions spec/swagger/swagger_doc_v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
- name: filter[rejection_reason]
in: query
Expand Down
1 change: 1 addition & 0 deletions swagger/v1/move.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ Move:
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
- type: 'null'
description: Reason the move has been cancelled
Expand Down
1 change: 1 addition & 0 deletions swagger/v1/move_cancellation_reason_attribute.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ MoveCancellationReason:
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
description: The reason the move has been cancelled
1 change: 1 addition & 0 deletions swagger/v2/move.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ Move:
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
- type: "null"
description: Reason the move has been cancelled
Expand Down
1 change: 1 addition & 0 deletions swagger/v2/patch_move.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ Move:
- supplier_declined_to_move
- cancelled_by_pmu
- rejected
- incomplete_per
- other
- type: "null"
description: Reason the move has been cancelled
Expand Down

0 comments on commit b73055d

Please sign in to comment.