Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RST-5596 remove token in url and replace it with security code functi… #54

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

itoulou
Copy link
Contributor

@itoulou itoulou commented Aug 15, 2023

</p>

<form method="POST">
{{ form.csrf_token }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this reference to csrf_token still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is. Needs to be referenced in all flask forms on the app otherwise Flask will complain that it's missing

Copy link
Contributor

@mark-butler-solirius mark-butler-solirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise looks good.

Copy link
Contributor

@mark-butler-solirius mark-butler-solirius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@itoulou itoulou merged commit 669e457 into staging Sep 18, 2023
2 checks passed
@itoulou itoulou deleted the RST-5596-session-token-in-url branch September 18, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants