Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EL-1431: Search page - Update styling #229

Merged
merged 32 commits into from
Apr 19, 2024
Merged

Conversation

MazOneTwoOne
Copy link
Contributor

@MazOneTwoOne MazOneTwoOne commented Apr 5, 2024

What does this pull request do?

  • Updating FALA landing / search page with new design changes

Any other changes that would benefit highlighting?

Checklist

  • Provided JIRA ticket number in the title, e.g. "LGA-152: Sample title"

@MazOneTwoOne MazOneTwoOne marked this pull request as ready for review April 9, 2024 15:40
@MazOneTwoOne MazOneTwoOne requested review from davidread and a team as code owners April 9, 2024 15:40
fala/apps/adviser/forms.py Outdated Show resolved Hide resolved
fala/apps/adviser/forms.py Outdated Show resolved Hide resolved
@psweeting1

This comment was marked as outdated.

@psweeting1

This comment was marked as resolved.

fala/apps/adviser/forms.py Outdated Show resolved Hide resolved
fala/urls.py Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@exonian exonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't deny my eyes glazed over slightly for the html, but nothing jumped out, and the Python looks good

Copy link
Contributor

@psweeting1 psweeting1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MazOneTwoOne MazOneTwoOne merged commit a78e0f1 into master Apr 19, 2024
9 of 10 checks passed
@MazOneTwoOne MazOneTwoOne deleted the EL-1431-search-page branch April 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants