Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPT-1932 London disclosure ICO SAR appeal decision update #2523

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

CDPT-1932 London disclosure ICO SAR appeal decision update #2523

wants to merge 30 commits into from

Conversation

njpreddy
Copy link
Contributor

@njpreddy njpreddy commented Dec 10, 2024 •
edited by vertism
Loading

Description

When an ICO SAR is sent to ICO, the outcome of the complaint needs to be recorded.

njpreddy and others added 19 commits November 28, 2024 09:33
@njpreddy
Update button text
385dd34
@njpreddy
Remove errant comma
0821344
@njpreddy
WIP
7043c7b 
- Add radio button options to model.
- Add new complaint outcome page.
- Add page title to locale.
- Add button title to locale.
@njpreddy
WIP
cbaeb4e 
Updated outcome key names.
Added json accessor property.
@njpreddy
Update SAR case parameters
3bd028a
@njpreddy
WIP
3827355 
- Shortened sar_complaint_outcome(s) references to complaint_outcome(s).
- Deleted shared option file.
- Tepmporarily hard code radio button options.
@njpreddy
WIP
2e3bee8 
- Add outcome recording method to controller.
- Amend SAR case params
- Amend model outcome constant and accessor.
- Amend outcome radio button rendering.
@njpreddy
wip
efa59d4
@njpreddy
Updated complaint outcome page.
654a23d
@njpreddy
Update routes
dc01604
@njpreddy
WIP
e8f3510 
- Updated workflow branch logic for timely ICO SARs.
- Remove empty line to fix rubocop offence
@njpreddy
WIP
b719739
@njpreddy
Un-comment form options.
17d23a7
@njpreddy
wip 16.04 13.01.2025
edba587
@njpreddy
Use %i for array of symbols.
2166348
@njpreddy
Add other SAR complaint outcome note field
00b8fd6
@njpreddy
Enlarged SAR complaint outcome note text area.
53701c0
@vertism
Merge branch 'main' into cdpt-1932-london-disclosure-ico-sar-appeal-d…
0f37823 
…ecision-update
@vertism
Add new page into current process
227a4cb
@vertism vertism changed the title CDPT-1932 London disclosure ICO SAR appeal decision updat. CDPT-1932 London disclosure ICO SAR appeal decision update Jan 22, 2025
@vertism vertism deployed to development January 23, 2025 15:44 — with GitHub Actions Active
@vertism vertism marked this pull request as ready for review January 23, 2025 16:16
@vertism vertism requested review from a team as code owners January 23, 2025 16:16
MeenaModhvadia
MeenaModhvadia approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@MeenaModhvadia MeenaModhvadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MeenaModhvadia MeenaModhvadia MeenaModhvadia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@njpreddy @MeenaModhvadia @vertism