PIC-4134 put service account name in pod name - useful for namespaces… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with multiple service accounts
markreesmoj
commented
Sep 9, 2024
| @@ -1,6 +1,6 @@ | |||
| locals { | |||
| # Generic configuration | |||
| identifier = "cloud-platform-${random_id.name.hex}" | |||
| identifier = "cp-${random_id.name.hex}" | |||
There was a problem hiding this comment.
Shortening the prefix to reduce the chance of hitting the 64 character limit
I wonder if the service name could replace the random_id part instead?
Co-authored-by: Jaskaran Sarkaria <[email protected]>
Co-authored-by: Jaskaran Sarkaria <[email protected]>
Co-authored-by: Jaskaran Sarkaria <[email protected]>
sj-williams
reviewed
Oct 21, 2024
sj-williams
reviewed
Oct 21, 2024
sj-williams
reviewed
Oct 21, 2024
sj-williams
requested changes
Oct 21, 2024
Co-authored-by: Steve Williams <[email protected]>
Co-authored-by: Steve Williams <[email protected]>
Co-authored-by: Steve Williams <[email protected]>
sj-williams
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with multiple service accounts