Skip to content

Commit

Permalink
Merge pull request #77 from ministryofjustice/bump-example
Browse files Browse the repository at this point in the history
Bump example version
  • Loading branch information
jakemulley authored May 9, 2023
2 parents 5db7b4f + 74f6f08 commit 9924a21
Showing 1 changed file with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions examples/ecr.tf
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,10 @@
*
*/
module "ecr_credentials" {
source = "github.com/ministryofjustice/cloud-platform-terraform-ecr-credentials?ref=5.0"
source = "github.com/ministryofjustice/cloud-platform-terraform-ecr-credentials?ref=5.1.4"
team_name = var.team_name
repo_name = "${var.namespace}-ecr"

/*
By default scan_on_push is set to true. When this is enabled then all images pushed to the repo are scanned for any security
/ software vulnerabilities in your image and the results can be viewed in the console. For further details, please see:
https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-scanning.html
To disable 'scan_on_push', set it to false as below:
scan_on_push = "false"
*/

# Uncomment and provide repository names to create github actions secrets
# containing the ECR name, AWS access key, and AWS secret key, for use in
# github actions CI/CD pipelines
Expand All @@ -26,6 +18,9 @@ module "ecr_credentials" {
# https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#environment-secrets
# github_environments = ["my-environment"]

# Uncomment to configure OIDC for GitHub Actions rather than using access keys
# oidc_providers = ["github"]

/*
# Lifecycle_policy provides a way to automate the cleaning up of your container images by expiring images based on age or count.
# To apply multiple rules, combined them in one policy JSON.
Expand Down

0 comments on commit 9924a21

Please sign in to comment.