Implement Applicants dob with gov_uk_date_fields
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to have the ability of calling callbacks, which is needed by the `gov_uk_date_fields` gem.
Also controller and view. As we want this field to behave as a `gov_uk_date`, we mark it as such with `acts_as_gov_uk_date :dob`
For the fields generated by the gem to be retrieved in the controller, those need to be whitelisted. These fields are (in the case of `dob`): dob_dd, dob_mm and dob_yyyy. As there could be more than a gov_uk_date field per form, the method will iterate through all the dates and build all the attribute names.
digitalronin
approved these changes
Nov 6, 2017
WillTaylor22
added a commit
that referenced
this pull request
Oct 20, 2022
Update dependency mimemagic to ~> 0.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual commits to make it easier to understand.
Still some polishing is needed as the markup the gem produce is not updated to what it should produce and thus the hint is a bit our of place, and the errors are not shown in the individual fields, only in the summary.
Also, no partial validation support with this gem (entering only month and year, and leaving blank the day, for example).