Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Secrets Manager read/write managed policy to the sso-admin permission set #981

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Adding Secrets Manager read/write managed policy to the sso-admin permission set #981

merged 1 commit into from
Sep 10, 2024

Conversation

julialawrence
Copy link
Contributor

Tracking story: ministryofjustice/analytical-platform#4271

This PR adds the AWS SecretsManagerReadWrite managed policy to the aws-sso-admin role so that we can retrieve, read and write secrets.

@julialawrence julialawrence requested a review from a team as a code owner September 10, 2024 08:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.58s
✅ REPOSITORY trivy yes no 10.33s
✅ TERRAFORM terraform-fmt 1 0 0.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@julialawrence julialawrence force-pushed the feature/add-secrets-manager-to-sso-admin-ps branch from 60835a1 to ee0b518 Compare September 10, 2024 08:36
connormaglynn
connormaglynn approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks Good To Me!

@julialawrence julialawrence merged commit d861090 into main Sep 10, 2024
5 of 6 checks passed
@julialawrence julialawrence deleted the feature/add-secrets-manager-to-sso-admin-ps branch September 10, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connormaglynn connormaglynn connormaglynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julialawrence @connormaglynn