Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ModernisationPlatformGithubActionsRole to delete *.tflock files #1085

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Jan 22, 2025

Tracked upstream by #8345.

This PR adds a statement allowing the ModernisationPlatformGithubActionsRole to delete native S3 lock files from the modernisation-platform-terraform-state S3 bucket.

@dms1981 dms1981 requested review from a team as code owners January 22, 2025 21:31
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 0.65s
✅ REPOSITORY trivy yes no 18.24s
✅ TERRAFORM terraform-fmt 1 0 0.05s
✅ TERRAFORM tflint yes no 12.16s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

@julialawrence julialawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 merged commit a6d88fb into main Jan 23, 2025
6 checks passed
@dms1981 dms1981 deleted the feature/8345-allow-deletion-of-tflock-files branch January 23, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants