Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Tidy Up Some Bits #1060

Merged
merged 3 commits into from
Dec 6, 2024
Merged

🧹 Tidy Up Some Bits #1060

merged 3 commits into from
Dec 6, 2024

Conversation

connormaglynn
Copy link
Contributor

👀 Purpose

  • To tidy up some dangling code/issues

♻️ What's changed

  • Removed the test Slack Alert workflow (all seems to be working now)
  • Removed the commit message from the Slack Alert - don't have time to figure out how to get this working and we can live without it
  • Fixed the gitleaks issues

📝 Notes

@connormaglynn connormaglynn requested a review from a team as a code owner December 5, 2024 17:54
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.04s
✅ REPOSITORY gitleaks yes no 0.83s
✅ REPOSITORY trivy yes no 25.73s
✅ YAML prettier 2 0 0.49s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

ewastempel
ewastempel approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ewastempel ewastempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@connormaglynn connormaglynn merged commit d35a54f into main Dec 6, 2024
5 checks passed
@connormaglynn connormaglynn deleted the tidy-up branch December 6, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewastempel ewastempel ewastempel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connormaglynn @ewastempel