Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop task from running if user cannot be found for whatever reason #1397

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

jamesstottmoj
Copy link
Contributor

📝 Summary

This PR relates to ministryofjustice/analytical-platform#6192

This PR completes task if user no longer exists in the database.

The changes in this PR are needed because this will silence an error thrown in Sentry as well as complete any tasks reran.

Merging this PR will have the following side-effects:

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

📚 Documentation status

  • No changes to the documentation are required

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesstottmoj jamesstottmoj merged commit ff1b95d into main Nov 28, 2024
11 checks passed
@jamesstottmoj jamesstottmoj deleted the fix/user-deletion-error branch November 28, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants