Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛂 Add statement for cross account assumption #1392

Merged
merged 16 commits into from
Nov 28, 2024
Merged

Conversation

jacobwoffenden
Copy link
Member

@jacobwoffenden jacobwoffenden commented Nov 18, 2024

This pull request:

Signed-off-by: Jacob Woffenden [email protected]

This is hidden behind a feature flag cloud_platform_assume_role that will need to be toggled to true in settings.yaml

Signed-off-by: Jacob Woffenden <[email protected]>
@jacobwoffenden jacobwoffenden requested a review from a team November 18, 2024 14:39
@jacobwoffenden jacobwoffenden self-assigned this Nov 18, 2024
@jamesstottmoj jamesstottmoj marked this pull request as ready for review November 25, 2024 10:08
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, added some suggestions that you might want look into

controlpanel/frontend/views/app.py Outdated Show resolved Hide resolved
settings.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesstottmoj jamesstottmoj merged commit 9ccef74 into main Nov 28, 2024
13 checks passed
@jamesstottmoj jamesstottmoj deleted the feat/xacct-iam-role branch November 28, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants