Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added potential fix to ignore particular helm errors that are causing… #1389

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

jamesstottmoj
Copy link
Contributor

… noises in Sentry

📝 Summary

This PR is linked to ministryofjustice/analytical-platform#5529

This PR silences particular helm errors that don't seem to affect tool deployment.

The changes in this PR are needed because it will reduce the number of errors sent to Sentry

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

📚 Documentation status

  • No changes to the documentation are required

@jamesstottmoj jamesstottmoj marked this pull request as ready for review November 15, 2024 10:15
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approving on agreement that we test changes in dev thoroughly before promoting to prod

@jamesstottmoj
Copy link
Contributor Author

After a bit of investigation, the errors seem to be caused because multiple workers are picking up the same job. One worker will successfully complete a helm command while the others attempt to and send us an error as a result.

@jamesstottmoj jamesstottmoj merged commit 7f92285 into main Nov 15, 2024
11 checks passed
@jamesstottmoj jamesstottmoj deleted the bugfix/ignore-helm-errors branch November 15, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants