Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR contributes to ministryofjustice/analytical-platform#3858
It reenables adding secrets to AWS Parameter Store for Airflow tasks only. Much of the code from the original implementation has been retained, with some changes to reflect it should only be used to add secrets related to Airflow tasks.
🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
-An aws role is required to test with, you can create one in the ap-dev account, ensuring the name starts with "airflow". Or if it has not been deleted yet, you can use the one that I have created named
airflow-dev-example-role
📚 Documentation status