Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/restore paramater store #1345

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

michaeljcollinsuk
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk commented Oct 4, 2024

📝 Summary

This PR contributes to ministryofjustice/analytical-platform#3858

It reenables adding secrets to AWS Parameter Store for Airflow tasks only. Much of the code from the original implementation has been retained, with some changes to reflect it should only be used to add secrets related to Airflow tasks.

🔍 What should the reviewer concentrate on?

  • Code changes made to restrict use for Airflow only

🧑‍💻 How should the reviewer test these changes?

-An aws role is required to test with, you can create one in the ap-dev account, ensuring the name starts with "airflow". Or if it has not been deleted yet, you can use the one that I have created named airflow-dev-example-role

  • Run the branch locally
  • Go to the Parameters tab
  • Create a new parameter, selecting the a valid role
  • After submitting, go to AP-compute dev > Parameter Store and check that the secret has been added and looks correct. It should be the type "SecureString"
  • Back in control panel, delete the parameter you created using the button on the parameter list page
  • Check that it has been deleted as expected in the AP-dev AWS parameter store

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation in the User Guidance will be updated separately

@michaeljcollinsuk michaeljcollinsuk marked this pull request as ready for review October 4, 2024 14:28
@jacobwoffenden
Copy link
Member

@michaeljcollinsuk michaeljcollinsuk merged commit bd1f542 into main Oct 8, 2024
12 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/restore-paramater-store branch October 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Manage AWS Parameters (or secrets) via AP console
2 participants