Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing malformed policy bug in oidc roles #4662

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

julialawrence
Copy link
Contributor

@julialawrence julialawrence commented Jul 9, 2024

Pull Request Objective

This piece of work is being tracked in #4358 GitHub Issue.

This is fixing the malformed policy error when no target role is specified in the oidc role config.
Introduced in this PR: #4648

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Terraform Component 🧱: aws-analytical-platform-oidc

Checkov 🛂: failure

Trivy 🛂: success

Static Analysis Override Label 🏷️: true

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform/oidc, Workflow: Terraform, Marker: aws-analytical-platform-oidc_static_analysis

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Terraform Component 🧱: aws-analytical-platform-oidc

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @julialawrence, Action: pull_request, Working Directory: terraform/aws/analytical-platform/oidc, Workflow: Terraform, Marker: aws-analytical-platform-oidc_plan

@julialawrence julialawrence marked this pull request as ready for review July 9, 2024 11:56
@julialawrence julialawrence requested a review from a team as a code owner July 9, 2024 11:56
Copy link
Contributor

@Gary-H9 Gary-H9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julialawrence julialawrence merged commit 110b774 into main Jul 9, 2024
23 checks passed
@julialawrence julialawrence deleted the bugfix/malformed-policy-exception-in-oidc branch July 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants