Add IRSA to airflow dev environment #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Component 🧱:
|
Terraform Component 🧱:
|
julialawrence
requested changes
Jun 4, 2024
terraform/aws/analytical-platform-data-production/airflow/iam-policies.tf
Outdated
Show resolved
Hide resolved
terraform/aws/analytical-platform-data-production/airflow/kubernetes-service-accounts.tf
Outdated
Show resolved
Hide resolved
julialawrence
requested changes
Jun 4, 2024
There was a problem hiding this comment.
A few more general thoughts/questions that might not lead to any changes:
- Namespaces are defined in eks.tf. Should service account definitions live in that file as well? Or the reverse. Should namespace definitions be split out into their own separate file? Would love to hear your thoughts on that.
- What's the plan on removing existing kube2iam annotations. In a future PR?
terraform/aws/analytical-platform-data-production/airflow/iam-policies.tf
Outdated
Show resolved
Hide resolved
julialawrence
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Nicely done! Please hold off merging until discussing with @Gary-H9
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jacobwoffenden
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Objective
This piece of work is being tracked in this GitHub Issue.
This PR adds IRSA to airflow dev environment. This is to initially test with the airflow monitoring DAG here.
Note: SCA overridden due to historic issues leading to failures, not from changes in this PR.