Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add coredns addon to airflow-dev #3003

Merged
merged 3 commits into from
Jan 18, 2024
Merged

add coredns addon to airflow-dev #3003

merged 3 commits into from
Jan 18, 2024

Conversation

Emterry
Copy link
Contributor

@Emterry Emterry commented Jan 18, 2024

This pr is to add the coredns addon into code rather than aws managed in the airflow-dev cluster. This links to issue #2812

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Checkov 🛂: failure

Trivy 🛂: failure

Static Analysis Override Label 🏷️: true

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_static_analysis

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited
Loading

Terraform Component 🧱: aws-analytical-platform-data-production-airflow

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @Emterry, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/airflow, Workflow: Terraform, Marker: aws-analytical-platform-data-production-airflow_plan

@Emterry Emterry marked this pull request as ready for review January 18, 2024 11:39
@Emterry Emterry requested a review from a team January 18, 2024 11:39
jhpyke
jhpyke approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@jhpyke jhpyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

@Emterry Emterry merged commit 772fffc into main Jan 18, 2024
14 checks passed
@Emterry Emterry deleted the coreDns-addon branch January 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpyke jhpyke jhpyke approved these changes

Assignees

@Emterry Emterry

Labels
override-static-analysis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emterry @jhpyke