Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Design for live preview of VS code #5774

Closed
YvanMOJdigital opened this issue Oct 22, 2024 · 1 comment
Closed

Spike: Design for live preview of VS code #5774

YvanMOJdigital opened this issue Oct 22, 2024 · 1 comment
Labels
spike investigation, discovery into a thing

Comments

@YvanMOJdigital
Copy link

YvanMOJdigital commented Oct 22, 2024

Context

Proposal

We should see if the simple browser in vs code actually works first

  1. Add a new server block to NGINX similar to https://github.com/ministryofjustice/analytical-platform-cloud-development-environment-nginx-proxy/blob/main/src/etc/nginx/nginx.conf.template#L158 but listening on n+1 port and exposing another upstream port e.g. 8081
  2. Update the deployment and service to surface this new proxy port
  3. Expose this via a new ingress ${USERNAME}-${CDE_TOOL}-tunnel.${CDE_DOMAIN}

Spike Requirements

Definition of Done

@jacobwoffenden
Copy link
Member

Done as part of #4167

@github-project-automation github-project-automation bot moved this from 👀 TODO to 🎉 Done in Analytical Platform Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike investigation, discovery into a thing
Projects
Archived in project
Development

No branches or pull requests

2 participants