-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Consolidate NGINX proxy #4167
Comments
This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open. |
This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open. |
This issue is being closed because it has been open for a further 7 days with no activity. If this is still a valid issue, please reopen it, Thank you! |
relates to #5010 |
VS Code 2.5.1 shipped with this functionality |
User Story
As an Analytical Platform product engineer
I want one NGINX proxy
So that we reduce the amount of NGINX proxies we need to maintain
Value / Purpose
We've got two unmaintained NGINX proxies that probably should be merged and updated
https://github.com/ministryofjustice/analytical-platform-nginx-proxy
https://github.com/ministryofjustice/analytical-platform-nginx-proxy-jupyter
Useful Contacts
@jacobwoffenden
User Types
Analytical Platform Product Engineering
Hypothesis
If we... [do a thing]
Then... [this will happen]
Proposal
One image to rule them all, with multiple configs embedded, that can be chosen based on the running tool
Additional Information
https://nedjalkov-ivan-j.medium.com/jupyter-lab-behind-a-nginx-reverse-proxy-the-docker-way-8f8d825a2336
https://jupyter-docker-stacks.readthedocs.io/en/latest/using/recipes.html#running-behind-an-nginx-proxy
https://gist.github.com/cboettig/8643341bd3c93b62b5c2
Definition of Done
The text was updated successfully, but these errors were encountered: