Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Consolidate NGINX proxy #4167

Closed
6 tasks done
jacobwoffenden opened this issue Apr 23, 2024 · 6 comments
Closed
6 tasks done

🔥 Consolidate NGINX proxy #4167

jacobwoffenden opened this issue Apr 23, 2024 · 6 comments
Assignees
Labels

Comments

@jacobwoffenden
Copy link
Member

jacobwoffenden commented Apr 23, 2024

User Story

As an Analytical Platform product engineer
I want one NGINX proxy
So that we reduce the amount of NGINX proxies we need to maintain

Value / Purpose

We've got two unmaintained NGINX proxies that probably should be merged and updated
https://github.com/ministryofjustice/analytical-platform-nginx-proxy
https://github.com/ministryofjustice/analytical-platform-nginx-proxy-jupyter

Useful Contacts

@jacobwoffenden

User Types

Analytical Platform Product Engineering

Hypothesis

If we... [do a thing]
Then... [this will happen]

Proposal

One image to rule them all, with multiple configs embedded, that can be chosen based on the running tool

Additional Information

https://nedjalkov-ivan-j.medium.com/jupyter-lab-behind-a-nginx-reverse-proxy-the-docker-way-8f8d825a2336

https://jupyter-docker-stacks.readthedocs.io/en/latest/using/recipes.html#running-behind-an-nginx-proxy

https://gist.github.com/cboettig/8643341bd3c93b62b5c2

Definition of Done

Copy link
Contributor

github-actions bot commented Jul 7, 2024

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

@github-actions github-actions bot added the stale label Jul 7, 2024
@jacobwoffenden jacobwoffenden removed data-platform-apps-and-tools This issue is owned by Data Platform Apps and Tools stale labels Jul 8, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

This issue is being marked as stale because it has been open for 60 days with no activity. Remove stale label or comment to keep the issue open.

@github-actions github-actions bot added the stale label Sep 7, 2024
Copy link
Contributor

This issue is being closed because it has been open for a further 7 days with no activity. If this is still a valid issue, please reopen it, Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2024
@github-project-automation github-project-automation bot moved this from 👀 TODO to 🎉 Done in Analytical Platform Sep 14, 2024
@jacobwoffenden jacobwoffenden reopened this Oct 8, 2024
@github-project-automation github-project-automation bot moved this from 🎉 Done to 🚀 In Progress in Analytical Platform Oct 8, 2024
@jacobwoffenden
Copy link
Member Author

relates to #5010

@jacobwoffenden
Copy link
Member Author

Running a simple server on port 8081:

Image

Accessing simple server using -tunnel host name

Image

@jacobwoffenden
Copy link
Member Author

VS Code 2.5.1 shipped with this functionality

@github-project-automation github-project-automation bot moved this from 🛂 In Review to 🎉 Done in Analytical Platform Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant