Feature/embed quicksight #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljcollinsuk
force-pushed
the
feature/embed-quicksight
branch
5 times, most recently
from
1ad9ff0 to
be47dd4
Compare
…JWT as dependency
Static analysis includes checkov, which installed a version of botocore that conflicted with the version pinned in the requirements. It also installed packages as the root user, which meant when trying to upgrade botocore, a permission error was raised as the vscode user that runs the dev container does not have permission to remove packages installed as root. We dont need to run checkov locally so removing, which resolves the issue.
Display welcome message, login button, fix styling on the login fail page.
We only want to default to using STS to retrieve AWS credentials when not using a service role that already has permission to call services. These changes attempt to make that more explicit. For now, we should only default to using STS when running locally.
michaeljcollinsuk
force-pushed
the
feature/embed-quicksight
branch
from
be47dd4 to
2e10139
Compare
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow testing in dev, this pull request adds a MVP implementation of the following:
analytical-platform-compute-developmentaccount in eu-west-2awsapp with code to interact with AWS services. This has been written so that when running locally, an AWS role that has permission to interact with Quicksight and Glue (and other AWS services) is assumed by boto. This is because none of the AWS profiles we can use locally have permissions required to run the app.DEFAULT_STS_ROLE_TO_ASSUMEenv var should only be set locally.To run locally:
.envfile. Instructions have been added to the README about attaining this via 1password CLI.http:localhost:8000in your browser.