Rubocop fixes #7988
Merged
Rubocop fixes #7988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmhaig
force-pushed
the
rubocop
branch
2 times, most recently
from
18cbd2d to
5595f54
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix a few more Rubocop issues.
Ticket
N/A
Why
General housekeeping.
How
Fix
Metrics/MethodLengthin;app/controllers/pages_controller.rbspec/models/remote/case_type_spec.rbspec/support/matchers/hash_matchers.rbRemove;
app/services/message_queue/message_template.rb. This has not been used since Remove SQS for AGFS #2231.CaseWorkers::Admin::AllocationsHelper.owner_column_header. This has not been used since Claim totals + VAT break downs #1901.ClaimsHelper.claim_allocation_checkbox_helper. This has not been used since [CFP-331] Removal of dead codes #4442.Note: Although these do not appear to be used anymore this should be monitored after merging to ensure that there are no side-effects.