Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v7.0.0 #2367
base: master
Are you sure you want to change the base?
Release v7.0.0 #2367
Changes from 4 commits
937e20f
e4ffd01
6167902
08e61ff
976d095
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the migration/upgrade path here?
What needs to change on an existing tenant for the update to work?
Or are these not expected to break workflows if you have a tenant using them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Tenant CRD is as simple as update the Operator version, it is not going to be disruptive at all.
For the MinIO Job there is no replacement in the Operator, AIStor have a similar functionality for enterprise, the AdminJob, I would say the recommendation if MinIOJob is needed, to move to the AIStor operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if someone has an existing MinioJob YAML its just going to stop working with 7.0.
FOr PDB same - do they have to scrub PDB from tenant first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, MinIOJob will stop working on 7.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MinIOJob is a one-time operation.
@pjuarezd Does Helm remove the CRD during upgrade? If not then we may want to add code to deal with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the Helm upgrade will remove the CRD @ramondeklein
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So no other changes are required for upgrade? An existing tenant w/ PDB settings should still work in 7.0.0 - or are we asking them to scrub PDB settings first @pjuarezd