Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add portName to container #2347

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 21, 2024

feat:add portName to container
fix #2326

feat:add portName to container
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should name all ports if we start to name one. I don't think this can potentially break anything?

adds more
@jiuker jiuker requested a review from ramondeklein October 21, 2024 09:52
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramondeklein ramondeklein merged commit 2c867b2 into minio:master Oct 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add port names to container ports
4 participants