Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect error log Waiting for MinIO to be ready: %!s(<nil>) #2345

Merged
merged 2 commits into from
Oct 25, 2024
Merged

fix: incorrect error log Waiting for MinIO to be ready: %!s(<nil>) #2345

merged 2 commits into from
Oct 25, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Oct 18, 2024 •
edited
Loading

fix: incorrect error log
Waiting for MinIO to be ready: %!s(<nil>)
fix #2308

@jiuker jiuker changed the title fix: incorrect error log fix: incorrect error log Waiting for MinIO to be ready: %!s(<nil>) Oct 18, 2024
fix: incorrect error log
8af2ff9 
fix: incorrect error log
@jiuker jiuker force-pushed the fix-incorrect-error-log branch from 19eed08 to 8af2ff9 Compare October 18, 2024 03:31
@jiuker jiuker requested review from pjuarezd, cniackz, ramondeklein and dvaldivia and removed request for pjuarezd and cniackz October 18, 2024 03:32
shtripat
shtripat previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ramondeklein
ramondeklein requested changes Oct 18, 2024
View reviewed changes
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
@jiuker jiuker requested a review from ramondeklein October 18, 2024 09:37
@jiuker jiuker self-assigned this Oct 21, 2024
@jiuker jiuker requested a review from shtripat October 24, 2024 08:14
allanrogerr
allanrogerr approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@allanrogerr allanrogerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesnietor cesnietor merged commit 0d8f857 into minio:master Oct 25, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanrogerr allanrogerr allanrogerr approved these changes

@cesnietor cesnietor cesnietor approved these changes

@shtripat shtripat shtripat approved these changes

@ramondeklein ramondeklein ramondeklein approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees

@jiuker jiuker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken error log message: "Waiting for MinIO to be ready: %!s(<nil>)"
5 participants
@jiuker @ramondeklein @shtripat @cesnietor @allanrogerr