Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty tenant log #2324

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: empty tenant log #2324

merged 1 commit into from
Sep 25, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 24, 2024

When update failed, tenant will reset to the default one without any information

minio-operator-bdb6b4f55-bkdg7 operator E0909 07:20:34.734171       1 main-controller.go:1570] error syncing '/': resource name may not be empty
minio-operator-bdb6b4f55-bkdg7 operator E0909 07:21:34.735160       1 main-controller.go:1570] error syncing '/': resource name may not be empty
minio-operator-bdb6b4f55-bkdg7 operator E0909 07:22:34.736224       1 main-controller.go:1570] error syncing '/': resource name may not be empty
minio-operator-bdb6b4f55-bkdg7 operator E0909 07:23:34.737242       1 main-controller.go:1570] error syncing '/': resource name may not be empty
minio-operator-bdb6b4f55-bkdg7 operator E0909 07:24:34.737571       1 main-controller.go:1570] error syncing '/': resource name may not be empty

fix: empty tenant log
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what could be the reason of updating pool status to fail?

@jiuker
Copy link
Contributor Author

jiuker commented Sep 25, 2024

LGTM, but what could be the reason of updating pool status to fail?

Update conflicts

@ramondeklein
Copy link
Contributor

Wouldn't skipping this result in an improper status? Shouldn't we retry determining the status if it hits a conflict?

But this PR is better than before, so let's merge it anyway...

@harshavardhana harshavardhana merged commit 59398ea into minio:master Sep 25, 2024
21 checks passed
@jiuker
Copy link
Contributor Author

jiuker commented Sep 26, 2024

Wouldn't skipping this result in an improper status? Shouldn't we retry determining the status if it hits a conflict?

But this PR is better than before, so let's merge it anyway...

Yes, the tenant will be empty here, and the outermost layer will pass the tenant to the syncHandler for further processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants