Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid system cfg changed can't restart #2253

Merged
merged 9 commits into from
Aug 26, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Aug 5, 2024

fix: Avoid system cfg changed can't restart
how to test:

  1. deploy 4*1 tenant.
  2. wait green
  3. add the env like MINIO_LOGGER_WEBHOOK_ENDPOINT_ to tenant
  4. now will restart all the pod in one batch. Before one by one , but the restart pod will get this
{"level":"INFO","time":"2024-08-05T19:05:07.791137217Z","message":"Following servers have mismatching configuration [https://minio-pool-0-3.na-minio-hl.na-test-minio.svc.cluster.local:9000-\u003ehttps://minio-pool-0-1.na-minio-hl.na-test-minio.svc.cluster.local:9000 has incorrect configuration: Expected MINIO_* environment name and values across all servers to be same: Mismatching environment values: [MINIO_LOGGER_WEBHOOK_ENDPOINT_].]"}

And got stuck for this pod will never be ready.

jiuker added 3 commits August 5, 2024 11:32
fix: avoid system cfg changed pod can't restart
delete pdb
comment
@jiuker jiuker requested review from harshavardhana, ramondeklein, shtripat, cniackz and pjuarezd and removed request for harshavardhana August 5, 2024 03:36
lint
init
@jiuker jiuker requested a review from harshavardhana August 6, 2024 03:37
harshavardhana
harshavardhana previously approved these changes Aug 10, 2024
@harshavardhana
Copy link
Member

PTAL @ramondeklein @pjuarezd

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think aborting the deletion of pods half-way should be avoided...

pkg/controller/pods.go Show resolved Hide resolved
pkg/controller/pods.go Outdated Show resolved Hide resolved
pkg/controller/pods.go Outdated Show resolved Hide resolved
pkg/controller/pods.go Show resolved Hide resolved
pkg/controller/pools.go Outdated Show resolved Hide resolved
pkg/controller/pools.go Outdated Show resolved Hide resolved
Co-authored-by: Ramon de Klein <[email protected]>
apply suggestion
@jiuker jiuker requested a review from ramondeklein August 12, 2024 03:52
lint
ramondeklein
ramondeklein previously approved these changes Aug 12, 2024
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor ones

pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/main-controller.go Outdated Show resolved Hide resolved
pkg/controller/pods.go Outdated Show resolved Hide resolved
pkg/controller/pools.go Outdated Show resolved Hide resolved
apply suggestoin
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjuarezd pjuarezd merged commit 3f1a37b into minio:master Aug 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants