-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Avoid system cfg changed can't restart #2253
fix: Avoid system cfg changed can't restart #2253
Conversation
fix: avoid system cfg changed pod can't restart
delete pdb
PTAL @ramondeklein @pjuarezd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think aborting the deletion of pods half-way should be avoided...
Co-authored-by: Ramon de Klein <[email protected]>
apply suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor ones
apply suggestoin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fix: Avoid system cfg changed can't restart
how to test:
MINIO_LOGGER_WEBHOOK_ENDPOINT_
to tenantAnd got stuck for this pod will never be ready.