Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current usage of the
TenantCapacity
component works on the formulacapacity_usage/capacity_raw
.capacity_usage
is the sum of all the used space on all disks as calculated by themadmin.AdminClient.StorageInfo
functioncapacity_raw
is the sum of all the PVC capacities on each volume on each server.Since
capacity_usage
can be greater thatcapacity_raw
, the resulting TenantCapacity component will show 100% usage, visually showing the tenant as out of storage.Fix
A better comparison would be
capacity_usage/(capacity+capacity_usage)
wherecapacity
is the sum of all the available space on all disks as calculated by themadmin.AdminClient.StorageInfo
function.Test
Create a MinIO operator tenant.
Create and populate a bucket.
Observe the
TenantCapacity
component correctly indicate the proportion of usage of the available storage; and not exceed 100% while approaching it.