Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tolerations to have Seconds undefined #2168

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

cesnietor
Copy link
Contributor

@cesnietor cesnietor commented Jun 18, 2024

fixes: #1595
fixes: #1298

Since Effect can't be other than NoExecute when Toleration Seconds are set, we need to allow Seconds to be undefined.
We address this by doing the validation in the BE and returning an error.

Test steps

  • Add a Tenant instance defining some Tolerations
  • Set one toleration without seconds
  • Set one with seconds set
  • They should show up on the Settings
  • Go to Settings and check you can also add and update tolerations with and without seconds and exposing the corresponding error.

@cesnietor cesnietor self-assigned this Jun 18, 2024
@cesnietor cesnietor merged commit da7bf70 into minio:master Jun 18, 2024
31 checks passed
@djwfyi djwfyi mentioned this pull request Jul 18, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants