Reload certificates in operator-ca-tls secrets
#2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjuarezd
changed the title
operator-ca-tls secrets
pjuarezd
force-pushed
the
reload-certificates
branch
from
4c7c8f3 to
2a74ff6
Compare
jiuker
previously approved these changes
May 24, 2024
shtripat
reviewed
May 24, 2024
…tificates stored in secrets with the prefix "operator-ca-tls." * No longer copy the secret `operator-ca-tls` from the operator namespace to the tenants namespace: Since [PR minio#1847](minio#1847), the secret `operator-ca-tls` is no longer mounted in the tenant, so there is no need to keep a copy. * `queue.NewNamedRateLimitingQueue` is deprecated and has been replaced with the recommended `queue.NewRateLimitingQueueWithConfig`. * Remove the duplicated method `getTLSSecret` and invoke `getCertificateSecret` instead. * Rename [generateTLSCert](https://github.com/minio/operator/blob/1c2fa4f402cc2c91c9903e6da6e9a693c92b65e4/pkg/controller/tls.go#L108) to `generateTLSCertificateForService` for better understanding. * Remove duplicated constants for 'public.crt', 'tls.crt', and 'ca.crt' in the `github.com/minio/operator/pkg/common` namespace. * Replace hardcoded strings 'public.crt', 'tls.crt', and 'ca.crt' with constants in the `github.com/minio/operator/pkg/certs` namespace. Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
pjuarezd
force-pushed
the
reload-certificates
branch
from
2a74ff6 to
2bfdd62
Compare
Signed-off-by: pjuarezd <[email protected]>
pjuarezd
force-pushed
the
reload-certificates
branch
from
2bfdd62 to
4b697b0
Compare
jiuker
approved these changes
May 25, 2024
pjuarezd
added a commit
to pjuarezd/operator
that referenced
this pull request
May 28, 2024
…Tenant namespace This was fixed by trusting CA's as soon as the secret changed on PR minio#2133 Signed-off-by: pjuarezd <[email protected]>
pjuarezd
added a commit
that referenced
this pull request
May 29, 2024
…nant namespace (#2137) No longer needed to create `operator-ca-tls` prefixed secrets on the Tenant namespace This was fixed by trusting CA's as soon as the secret changed on PR #2133 Signed-off-by: pjuarezd <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for secret changes in the operator namespace and trust TLS certificates stored in secrets with the prefix "operator-ca-tls"
operator-ca-tlsfrom the operator namespace to the tenants namespace. Since PR https://github.com/minio/operator/pull/1847 the secretoperator-ca-tlsis no longer mounted in the tenant, so there is no need to keep a copy in tenant namespace.queue.NewNamedRateLimitingQueueis deprecated and has been replaced with the recommendedqueue.NewRateLimitingQueueWithConfig.getTLSSecretand invokegetCertificateSecretinstead.generateTLSCertificateForServicefor better understanding.github.com/minio/operator/pkg/commonnamespace.github.com/minio/operator/pkg/certsnamespace.Signed-off-by: pjuarezd [email protected]