-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only create marketplace publish after container image have been published #2084
Conversation
@pjuarezd, this is a great idea! Thank you very much for the diagram; it explains the process really well. Approved! |
I just re-executed the 'test-tenant-upgrade' test because it was failing. I have a feeling there might be a change breaking the test, possibly related to a different PR. Let me investigate... |
Thank you @cniackz! |
The fix is in this PR: #2085: |
The fix for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but some minor remarks.
@pjuarezd Just another suggestion is that you can also use Mermaid to integrate flowcharts (and other diagrams) directly into GitHub (see docs). Live editor is available on https://mermaid.live. |
Thank you!, I will use it on following graphs! |
f037e97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…shed Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
Signed-off-by: pjuarezd <[email protected]>
Co-authored-by: Ramon de Klein <[email protected]>
f037e97
to
0ab3b58
Compare
This way we do
make generate-openshift-manifests
after Harsha published the containers.This is the Release flow proposal