-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the Krew plugin #2051
Conversation
There is an enterprise test using this for expand tenant feature test. We may need to change that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested and deployed the tenant with this compiled version. It shouldn't break functionality, although I agree with @shtripat that tests should catch up with the changes, as should the documentation. @ravindk89, please be aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvaldivia @cniackz
This is a breaking change to our users' workflows. Therefore how will this be announced, giving users sufficient time to change their workflows?
@dvaldivia @cniackz if I may suggest:
With this, we would
Users do not always track latest stable that closely, and can stay on 5.0.15 until they have readied their systems to move to Kustomize. Thoughts? |
There is no such workflow |
No we move to v6.0.0 - we break this and bump the major version. |
What is the timeline for this? It's a major change to how docs describes the k8s install process. We do have some preliminary docs for kustomize in GitHub, but multiple pages in the web docs need rework to feature that instead of krew. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider the changes to goreleaser made here: #2062
Signed-off-by: Daniel Valdivia <[email protected]>
001b6d1
to
ceff120
Compare
The change that was taken into consideration is now gone!
The conflict has been resolved, and now I'm awaiting the completion of tests. Once they pass, I'll request the team to review again, and then proceed with the merge. |
https://build.opensuse.org/request/show/1172784 by user ojkastl_buildservice + dimstar_suse kubectl-minio was deprecated upstream, see minio/operator#2051
We are deprecating the krew plugin in favor of focusing on the
kustomize
andhelm
approach of installing the operator.